dnt icon indicating copy to clipboard operation
dnt copied to clipboard

Doesn't add @types/ws if webSocket shim is enabled but the `test` option is set to false

Open rojvv opened this issue 1 year ago • 3 comments

rojvv avatar May 17 '24 20:05 rojvv

~~Can you post reproduction code?~~ Actually, is this during type checking that it fails? (while building?)

dsherret avatar May 17 '24 20:05 dsherret

I think a simple fix would be to just include @types packages from transformOutput.test.dependencies when type checking: https://github.com/denoland/dnt/blob/07ccc725bab65b21f187c08dfce0abd9d6c743e0/lib/package_json.ts#L66

dsherret avatar May 17 '24 20:05 dsherret

Yes, it is while building.

rojvv avatar May 17 '24 22:05 rojvv