deployctl icon indicating copy to clipboard operation
deployctl copied to clipboard

Incorrect entrypoint used, despite explicit config - `src` is prepended

Open Wolven531 opened this issue 3 years ago • 4 comments

https://github.com/denoland/deployctl/blob/60bd59cee271e49241c2bcfac41e8705d41fbecd/action/index.js#L54

Not sure this pattern is correct -

    url = new URL(`file:///src${entrypoint}`);

I would suggest

    url = new URL(`file:///${entrypoint}`);

Based on several attempts at using

a) filename pattern entrypoint b) file:/// pattern entrypoint c) relative to repo root pattern

The entrypoint variable for the GitHub Action does not work as expected

Each attempt below was performed after building index.js to dist (located in repository root in runner) and then re-attempted using /tmp/dist

image

The results are pretty consistent

image

image

image

image

Wolven531 avatar Jun 07 '22 06:06 Wolven531

Just to provide more context / examples, here's link to that repo's action runs -

https://github.com/Wolven531/deno-playground/actions

Wolven531 avatar Jun 07 '22 06:06 Wolven531

I had the same issue. I just "re-run failed jobs" and the error went away

xenofront avatar Nov 06 '22 15:11 xenofront

also getting this issue...

meyer9 avatar Oct 29 '23 00:10 meyer9

All the examples that are not erroring, and are only showing 0 files uploaded, are successful deployments. The action will only upload those files that changed.

I've forked your repo to test, here are the results:

Can you confirm you had changes in your code that should had been uploaded by weren't?

arnauorriols avatar Nov 09 '23 14:11 arnauorriols