deno_std
deno_std copied to clipboard
fix(msgpack): encode maps with null prototype
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.88%. Comparing base (
377043c) to head (5d0c608). Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4764 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 485 485
Lines 41308 41315 +7
Branches 5317 5320 +3
==========================================
+ Hits 37959 37964 +5
- Misses 3292 3294 +2
Partials 57 57
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please run
deno fmt.
thanks for remind
This 'is-plain-object' check seems mostly aligned with the implementation of npm:[email protected] https://github.com/sindresorhus/is-plain-obj/blob/v2.1.0/index.js and looks reasonable to me.
Is there a related issue?
it is not related to existed issue
- but in my case, objects are validated using
jsr:@oxi/schemaand then piped to theencode(), which throws an error because the validated objects are recreated by callingObject.create(null) - logically, objects without a prototype are the most "plain", isn't it?
Is there a related issue?
it is not related to existed issue
- but in my case, objects are validated using
jsr:@oxi/schemaand then piped to theencode(), which throws an error because the validated objects are recreated by callingObject.create(null)- logically, objects without a prototype are the most "plain", isn't it?
Fair justifications. For future reference, please be sure to include some context in the initial comment for PRs 🙂