chore(fs): remove flaky `emptyDir()` tests

Open iuioiua opened this issue 2 years ago • 2 comments

This PR removes flaky emptyDir() and emptyDirSync() tests.

These tests test Deno's permissions system, which is a runtime concern and outside the scope of the Standard Library. These tests were written a while ago in https://github.com/denoland/deno/pull/3501 and the permission system is a lot more robust today. I think it's fine for these tests to be removed.

Note: test coverage is not affected.

Dec 21 '23 03:12 iuioiua

What is the source of flakiness?

Dec 21 '23 07:12 kt3k

Most likely, the use of Deno.Command() in parallel.

Dec 21 '23 07:12 iuioiua

I'll close this for now until we confirm the cause of the flakes.

Dec 28 '23 02:12 iuioiua

Related #4022

Dec 28 '23 02:12 iuioiua