deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard
verified publisher icon denoland

fix(fs/walk): ignore broken symbolic links

Open joehillen opened this issue 2 years ago • 5 comments

Fixes #3452

joehillen avatar Jun 16 '23 03:06 joehillen

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 16 '23 03:06 CLAassistant

I'm going to pick this back up after https://github.com/denoland/deno_std/pull/3455 is merged. That way the broken links can be returned rather than simply dropped.

joehillen avatar Jul 19 '23 15:07 joehillen

Hi @joehillen, are you still happy to pursue this PR? If so, can you apply Yoshiya's previous suggestion and fix the merge conflicts?

iuioiua avatar Dec 11 '23 04:12 iuioiua

@iuioiua Thank you for the reminder. I had forgotten about this. Unfortunately I'm busy most of this week, but I'll be able to pick this up later this week or next.

joehillen avatar Dec 12 '23 19:12 joehillen

All good! Thanks for letting me know 👍🏾

iuioiua avatar Dec 12 '23 19:12 iuioiua

@iuioiua @kt3k Ready for review!

I've made several additional tweaks which are broken into small commits for easy review.

joehillen avatar Jan 05 '24 09:01 joehillen

PTAL @kt3k

iuioiua avatar Mar 11 '24 07:03 iuioiua

Closing as we have better way to handle broken symlinks. See https://github.com/denoland/deno_std/issues/3452#issuecomment-2058863401 for more details.

Also the API changes to expandGlob don't seem discussed very well. I don't find they are desirable changes.

kt3k avatar Apr 16 '24 11:04 kt3k