deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

feat(encoding/jsdoc): parse and stringify

Open timreichen opened this issue 2 years ago • 3 comments

  • adds jsdoc parse and stringify functions

timreichen avatar Sep 05 '22 19:09 timreichen

I'm not supportive of this. JSDoc isn't really an encoding thing, like JSON or CSV. It is decoration on an AST and deno_doc handles it as part of an AST. Code generation off of an AST is totally different than a "stringify" of encoding too.

kitsonk avatar Sep 05 '22 23:09 kitsonk

I agree with the upper comment, I don't think that this should be placed at the encoding folder too because like @kitsonk said, JSDoc isn't in fact related with encoding

luk3skyw4lker avatar Sep 07 '22 15:09 luk3skyw4lker

@kitsonk are you not in favour of the module as a whole or just current location?

timreichen avatar Sep 07 '22 19:09 timreichen

As a whole. deno_doc is where such parsing functionality should exist and codegen is a whole other kettle of fish.

kitsonk avatar Sep 14 '22 21:09 kitsonk

@kitsonk Ok, I think deno_doc could be used for that purpose as well as deno_std/tools. But could doc() add support for file paths next to urls? It works with file://, so I guess local paths shouldn't be a problem? Also, std/tools checks .rs files which are not supported by deno_doc. Is there a viable alternative to that?

timreichen avatar Sep 15 '22 09:09 timreichen

Closing in favour deno doc.

timreichen avatar Sep 23 '22 14:09 timreichen