deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

compat: `parallel/test-stream-writable-final-destroy.js` is broken

Open kt3k opened this issue 3 years ago • 2 comments

https://github.com/denoland/deno/pull/15522 seems to have broken parallel/test-stream-writable-final-destroy.js compat test case.

You can check it with the below steps:

deno upgrade --canary --version e96933bc163fd81a276cbc169b17f76724a5ac33
deno task node:test -- parallel/test-stream-writable-final-destroy.js   
deno upgrade --canary --version 97954003cc87b664768918173e8d00f6df35e04f
deno task node:test -- parallel/test-stream-writable-final-destroy.js   

kt3k avatar Aug 22 '22 10:08 kt3k

I suppose this was an already broken test, there were failed assertions within the callback passed to queueMicrotask() which were swallowed previously.

nayeemrmn avatar Aug 22 '22 13:08 nayeemrmn

Ah, makes sense. It was just a false negative

kt3k avatar Aug 22 '22 15:08 kt3k

Let's track in tools/node_compat/TODO.md in denoland/deno repo.

kt3k avatar Mar 21 '23 05:03 kt3k