deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

Published 20 hours ago • verified publisher icon denoland

feat(encoding): added XML parser

Open JuanM04 opened this issue 2 years ago • 6 comments

To-do:

  • [x] Implement parser
    • [x] Add multiple outputs
    • [ ] Add tests
  • [ ] Implement stringify
    • [ ] Add tests
    • [ ] Support multiple inputs (?)
  • [x] Added escape utility

JuanM04 avatar Jul 27 '22 01:07 JuanM04

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 27 '22 01:07 CLAassistant

This is a lot of work. Has there been a conversation with a core team member about this being a good contribution to deno_std? If so, it would be great to link to it or an issue where conversation has gone on.

kitsonk avatar Jul 27 '22 02:07 kitsonk

I did not have any conversation about this. I was experimenting with XML and, since Deno has support for YAML, TOML, CSV, and other common formats, I thought it would be a nice addition. If you don't think it should be integrated in deno_std, I could easily extract it into its own package

JuanM04 avatar Jul 27 '22 14:07 JuanM04

Is it possible to make this compatible with DOMParser API?

kt3k avatar Aug 01 '22 06:08 kt3k

Note that @b-fuze is independently thinking of adding integration with the XML parser xml5_ever in their deno_dom library (as per a conversation on the Deno discord).

andreubotella avatar Aug 01 '22 06:08 andreubotella

Having XML parser as part of deno_dom would be a lot better in my opinion. YAML, TOML, CSV are far more simplistic of parsers than XML.

kitsonk avatar Aug 01 '22 09:08 kitsonk

This has been idle for a few months. @kitsonk @kt3k do we want to move forward with this? If not, can we close it out?

cjihrig avatar Oct 04 '22 15:10 cjihrig

I'm in favor of closing this one for now.

I agree with @kitsonk . I think we should have xml parser as part of DOM API instead of invented API.

kt3k avatar Oct 04 '22 15:10 kt3k