deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

node: Handle "upgrade" event

Open bartlomieju opened this issue 3 years ago • 2 comments

bartlomieju avatar Jul 22 '22 00:07 bartlomieju

@bartlomieju Is it possible to write test case for upgrade behavior?

kt3k avatar Jul 22 '22 11:07 kt3k

Yes, I will write a test (or enable some Node tests) before landing.

bartlomieju avatar Jul 22 '22 11:07 bartlomieju

@kt3k I would like to land this PR without tests - I verified that it works with both Vite and express. Adding tests requires larger refactor that I'd like to tackle next week or two weeks after.

bartlomieju avatar Aug 18 '22 21:08 bartlomieju

Does Deno.serve supports listening on port 0 (= random available port)?

I see this message while running node/http_test.ts: Listening on http://localhost:0/

kt3k avatar Aug 19 '22 12:08 kt3k