deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

bug(std/_tools): 3rd party import

Open timreichen opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. std/_tools/check_circular_deps.ts is importing a 3rd party mod. std should never import from somewhere other than std. https://github.com/denoland/deno_std/blob/bcc57478422645cba01b9c75d34938e17ba8a383/_tools/check_circular_deps.ts#L3

Describe the solution you'd like Either remove the tool or have deno_graph be included into std.

Describe alternatives you've considered

timreichen avatar Jun 08 '22 00:06 timreichen

I think tools not transitively imported by any public module are exempt. Otherwise imported github actions wouldn't be allowed, the only difference is that these are written in Deno/TS.

nayeemrmn avatar Jun 08 '22 00:06 nayeemrmn

I agree with Nayeem. Scripts under _tools/ should be an exception of that rule

kt3k avatar Jun 09 '22 08:06 kt3k