deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

Include /x/redis as /std/redis

Open kt3k opened this issue 3 years ago • 3 comments

There seem strong demands/needs of redis client in the community. We should have one in std

ref: https://deno.land/x/redis

ref: https://news.ycombinator.com/item?id=31333025

External dependencies of /x/redis:

  • lodash-es/shuffle
  • lodash-es/sample
  • lodash-es/uniqBy
  • cluster-key-slot

kt3k avatar May 13 '22 12:05 kt3k

what makes redis different from mysql, postgres, mongodb, elasticsearch,... ? They are all popular. we can't just include redis driver in std and ignore the rest.

and if we add driver support for all popular databases, std would become a real mess. because each drivers has its own CI pipelines, testing structure and dependencies (like mongodb driver that depends on bson).

I don't think std is a place for third party drivers. instead of that, Deno can support denodrivers org so they can continue to develop drivers

erfanium avatar May 14 '22 10:05 erfanium

@erfanium We chose to try migrating redis (and sqlite) first because they have comparatively less external dependencies. (Also the maintainer welcomes the transition in case of redis)

We haven't decided on other drivers. We might take different path for other drivers depending on their situations

kt3k avatar May 16 '22 13:05 kt3k

I'm -1 on this. This is out of scope for std.

There seem strong demands/needs of redis client in the community.

If there is no community provided driver for an important database like redis, we can consider starting the effort. But I still think they should be maintained in separate modules/projects outside of std. The discoverability issue can be fixed with improved search.

piscisaureus avatar May 16 '22 17:05 piscisaureus

I'm -1 on this. This is out of scope for std.

I agree. I think we should close this issue.

iuioiua avatar Aug 24 '23 22:08 iuioiua