deno_lint
deno_lint copied to clipboard
feat(react): add use-jsx-in-jsx
Problem
- no place for react rules to live yet, until the plugin system gets ironed-out/formalized
Solution
- add in initial react rule
Discussion
I fully expect this to be rejected, but figured I'd use it as a discussion mechanism :)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@magurotuna what do you think? Maybe we should already go down the JS plugin route for this rule?
@bartlomieju Yeah I think it would be reasonable to provide lint rules for JSX as plugins rather than as builtin. It would be best to make the plugin system ready for use as soon as possible.
Currently linting my whole project in JS tools takes ~9 minutes. 🙏 Is a native or WASM/WASI plug-in mechanism is still under long term consideration?
Currently linting my whole project in JS tools takes ~9 minutes. 🙏 Is a native or WASM/WASI plug-in mechanism is still under long term consideration?
At the moment no, plugins would be JS/TS; but we expect it will still be way faster, because the "heavy lifting" like parsing and scope analysis would be done in Rust.
Gotcha, cool :)
closing because stale