deno_install icon indicating copy to clipboard operation
deno_install copied to clipboard

Update deno

Open mathiasrw opened this issue 4 years ago • 4 comments

Tried to update deno on my mac. Went to the website and use the install script indicated.

Took we a while to figure out the version number was the same as before.

After digging it turns out I installed it originally with brew.

I suggest that the feedback from the installation script gives the user a hint about something is not OK. It stats that it got installed successfully, but the new bin is not even in the path. It would be super helpful if the script did a small "where deno" with a test to see if the command is pointing to the newly installed bin and just inform the user that "Something seems a bit off, please investigate" (and maybe with a link to a website explaining what could be wrong)

image

Keep up the good work and lookinf forward to dive deeper into Deno :)

mathiasrw avatar May 03 '20 15:05 mathiasrw

Something like this might help:

  echo "Deno was installed successfully to $exe"
- if command -v deno >/dev/null; then
+ if [ "$(which deno)" = "$exe" ]; then
	echo "Run 'deno --help' to get started"
  else
	echo "Manually add the directory to your \$HOME/.bash_profile (or similar)"
        # ...
  fi

https://github.com/denoland/deno_install/blob/master/install.sh#L44

MarkTiedemann avatar May 03 '20 20:05 MarkTiedemann

same thing happened to me. I had installed with brew, but brew upgrade deno was still taking me to 1.0.0-rc2, so I used shell curl command to install.

sajidali avatar May 14 '20 16:05 sajidali

if you installed deno by brew, you may need to execute brew update before upgrading the deno version.

lovefengruoqing avatar May 20 '20 16:05 lovefengruoqing

WOuld be so good if Deno install was friendly and informed that "something is not right" giving the information needed to investigate.

Like if whereis deno | wc -l is greater than too print it out and ask the user to sort things out.

mathiasrw avatar May 20 '20 22:05 mathiasrw