deno_doc
deno_doc copied to clipboard
Fix location line and column
It seems the line and column on Location
is display oriented. There are two issues though:
- We're using a tab indent width of 4. Shouldn't it be 2 since we use 2 spaced indents in deno fmt?
- Currently the line is 1-indexed, but the column is 0-indexed.
All that said, should this even be "display" oriented?
It has been display oriented, because it is generally used to create external links to source code. The line is far more important than the column.
Personally I am fine either way, but changing it to not be display would be a non-trivial breaking change. Feels like we should be consistent though among deno_lint
and the LSP and any other places. We are all over the place when storing/representing stuff like this.