deno icon indicating copy to clipboard operation
deno copied to clipboard

Published 20 hours ago • verified publisher icon denoland

fix(terminal): Skip the cjs suggestion for mjs/mts modules

Open MohammadSu1 opened this issue 1 year ago • 2 comments

This PR is for solving #26557.

  1. A check statement was added to verify if the file ends with .mjs or .mts.
  2. If this condition is true, the CJS suggestions will be skipped.

MohammadSu1 avatar Nov 03 '24 07:11 MohammadSu1

Could you please add a test that uses .cts file?

bartlomieju avatar Nov 04 '24 10:11 bartlomieju

Sure! I will add a test asap

MohammadSu1 avatar Nov 04 '24 12:11 MohammadSu1

When I try to add a test that uses a .cts file, it shows me the following error: cts_problem

MohammadSu1 avatar Nov 05 '24 10:11 MohammadSu1

@MohammadSu1 can you push the failing test to the PR?

dsherret avatar Nov 08 '24 15:11 dsherret

@dsherret I tried fixing the issue in the test and pushed it to the PR. I think it's working correctly now

MohammadSu1 avatar Nov 10 '24 07:11 MohammadSu1

@dsherret Can you please review this PR?

MohammadSu1 avatar Nov 21 '24 10:11 MohammadSu1

@bartlomieju Can you please review this PR?

MohammadSu1 avatar Dec 02 '24 12:12 MohammadSu1

@dsherret Can you review this PR?

MohammadSu1 avatar Dec 15 '24 14:12 MohammadSu1

@dsherret Can you review this PR, please?

MohammadSu1 avatar Dec 30 '24 15:12 MohammadSu1