Compiled executable failed to find modules from custom npm registry containing subpath

[imfing]

Version: Deno 2.0.3

I have encountered this issue while working with a custom npm registry such as JFrog npm-registry. While Deno successfully caches, and executes scripts respecting the NPM_CONFIG_REGISTRY environment variable, compiling the script into an executable results in an ERR_MODULE_NOT_FOUND error for npm modules.

Steps to reproduce

the example was taken from the blog post, I was running Deno 2.0.3 in blank GitHub codespace (Linux), with custom public npm registry mirror:

$ export NPM_CONFIG_REGISTRY=http://mirrors.tencent.com/npm/

$ cat main.ts
import { say } from "npm:[email protected]";
console.log(say({ text: "Hello from Deno!" }));

$ deno run --allow-read main.ts
 __________________
< Hello from Deno! >
 ------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

$ deno compile --allow-read -o main main.ts
Compile file:///workspaces/codespaces-blank/main.ts to main

$ ./main
error: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///tmp/deno-compile-main/.deno_compile_node_modules/localhost/cowsay/1.5.0/index.js' imported from 'file:///tmp/deno-compile-main/codespaces-blank/main.ts'

Screenshot:

Additional info:

I found that using custom npm registry like $ export NPM_CONFIG_REGISTRY=http://registry.npm.taobao.org would work without issues. This leads me to suspect that the problem may be related to how Deno compile handles npm modules located under a subpath (e.g. http://custom-registry.com/path/to/npm/)

[imfing]

https://github.com/denoland/deno/blob/a8846eb70f96445753fe5f8f56e6155cb2d0fac6/cli/standalone/binary.rs#L767-L774

seem that the issue is caused by the assumption that all npm modules are located in <root_dir>/<registry_host>/...

in reality, the cached packages are actually stored in subdirectories, specifically under <root_dir>/<registry_host>/sub/path/...

[nomocas]

Version: Deno 2.3.3

Hello All,

This exact issue is still there. @imfing did you find any workaround ?

Thanks.

[imfing]

Version: Deno 2.3.3

Hello All,

This exact issue is still there. @imfing did you find any workaround ?

Thanks.

You can set up a local reverse proxy from e.g. http://localhost:3000 to http://custom-registry.com/path/to/npm/, and then configure NPM_CONFIG_REGISTRY to point to the local reverse proxy.

[nomocas]

Hello @imfing,

Ok thanks for the tips. In my case, adding the "vendor": true in the deno.json has done the job. It produces the local node_modules and includes it in the compiled file. In my case it was not an issue, even if it's not really clean.

[felipecrs]

I can confirm this issue, and also confirm that deno compile --vendor works around it.