feat: new inspector

Open devsnek opened this issue 1 year ago • 5 comments

implement local inspector

future changes:

wire up InspectorServer to enable open/close/url
wire up connectToMainThread

Fixes https://github.com/denoland/deno/issues/25004

Oct 22 '24 10:10 devsnek

What should the permissions be to access inspector?

Oct 22 '24 10:10 lucacasonato

What should the permissions be to access inspector?

That's a good question that I was wondering when I first started working on this. Do we need to add permissions at all?

Oct 22 '24 20:10 bartlomieju

@lucacasonato I spoke with @devsnek offline and we are thinking that we could piggy-back off of --allow-sys=inspector so that we don't have to add another --allow-* flag.

Oct 23 '24 12:10 bartlomieju

How confident are we that inspector does not imply --allow-run?

Oct 23 '24 12:10 lucacasonato

@lucacasonato I spoke to someone on the devtools team and they said it was ok.

Nov 04 '24 10:11 devsnek