deno icon indicating copy to clipboard operation
deno copied to clipboard

fix(permission): Address permissions issue for UNC paths on Windows

Open yazan-abdalrahman opened this issue 1 year ago • 3 comments

fix #24703

yazan-abdalrahman avatar Aug 21 '24 12:08 yazan-abdalrahman

@dsherret please can review this change?

yazan-abdalrahman avatar Aug 21 '24 12:08 yazan-abdalrahman

@dsherret @bartlomieju Hello, could you help verify why it failed? It works on my local. image

https://github.com/user-attachments/assets/5c4460d4-b9d3-4a08-a9f8-d8f15d74a48d

And when I ran the script, it didn't set failed to true, therefore it didn't output "One or more tests failed" and it didn't return 321.

https://github.com/user-attachments/assets/42e27d1b-475f-4760-831e-90e708ffd777

yazan-abdalrahman avatar Aug 21 '24 14:08 yazan-abdalrahman

@dsherret , I'm running into this issue while trying to open any UNC path or DOS device (eg, '\.\CONIN$') with non---allow-all permissions.

Is there any thoughts on what permissions (besides just defaulting to --allow-all) that could/should be used for this fairly common CLI and network script usage?

Requiring --allow-all is especially problematic as it can't be tested using the permissions API.

Should anyone else be included in the discussion?

Thanks for the attention.

rivy avatar Oct 06 '24 01:10 rivy

closing because old

ry avatar May 09 '25 00:05 ry