deno icon indicating copy to clipboard operation
deno copied to clipboard

fix(node:fs/promises): add missing cp and cpSync

Open jaw0r3k opened this issue 1 year ago • 2 comments

I dont think the pull request requires any tests Fixes a bug mentioned in https://github.com/discordjs/discord.js/issues/9810

As author of df062d2c788fd76546d59c67452d8d0fe569c533 added support for that didnt add it directly to fs/promises

jaw0r3k avatar Jan 22 '24 18:01 jaw0r3k

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 22 '24 18:01 CLAassistant

Thanks for the PR @jaw0r3k! I think it would be useful to have a test that checks for presence of these API - could you add some simple assertions that verify that promises.cp and promises.cpSync actually exist?

bartlomieju avatar Jan 23 '24 01:01 bartlomieju

Superseded by #22263

jaw0r3k avatar Feb 14 '24 13:02 jaw0r3k