deno icon indicating copy to clipboard operation
deno copied to clipboard

fix(ext/node): avoid own `toString` on error instances

Open LiviaMedeiros opened this issue 2 years ago • 2 comments

These errors shouldn't have enumerable toString properties.

The implementation is identical to the inherited from NodeErrorAbstraction, so overrides look redundant.

LiviaMedeiros avatar Aug 28 '23 09:08 LiviaMedeiros

Thanks for the PR @LiviaMedeiros, but it appears it causes some failures in compatibility tests from the Node.js codebase.

bartlomieju avatar Aug 28 '23 10:08 bartlomieju

Couldn't reproduce the failures locally; let's see if redefining them as non-enumerable works.

LiviaMedeiros avatar Aug 29 '23 07:08 LiviaMedeiros

closing this because it's old

ry avatar Mar 21 '25 02:03 ry