deno icon indicating copy to clipboard operation
deno copied to clipboard

feat(websockets): Narrow type of WebSocket message event

Open rotu opened this issue 2 years ago • 3 comments

rotu avatar Aug 12 '23 04:08 rotu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 12 '23 04:08 CLAassistant

We should use the same type as lib.dom.d.ts here.

That makes sense. Why aren't we importing these types from upstream e.g. WebSocketEventMap as declared in TypeScript or generating from with TypeScript-DOM-lib-generator?

rotu avatar Aug 18 '23 17:08 rotu

@rotu we use the exact same typings already as upstream TS

crowlKats avatar Oct 20 '24 13:10 crowlKats

I think this PR no longer makes sense as of #25545

rotu avatar Oct 20 '24 16:10 rotu