deno icon indicating copy to clipboard operation
deno copied to clipboard

Published 20 hours ago • verified publisher icon denoland

refactor(core): remove opAsync

Open littledivy opened this issue 2 years ago • 4 comments

littledivy avatar Jan 26 '23 11:01 littledivy

How was the "jitting" for the async functions done again? Did it rely on new Function usage?

aapoalas avatar Jan 26 '23 11:01 aapoalas

How was the "jitting" for the async functions done again? Did it rely on new Function usage?

It's done in 01_core.js in initializeAsyncOps and yes, it uses new Function, but that's problematic as described in https://github.com/denoland/deno/issues/16535 and Divy will rework it to do it from Rust side.

bartlomieju avatar Jan 28 '23 12:01 bartlomieju

@littledivy is anything blocking this PR?

bartlomieju avatar Feb 02 '23 22:02 bartlomieju

Please wait for https://github.com/denoland/deno/pull/17648 to land before merging this PR.

bartlomieju avatar Feb 06 '23 22:02 bartlomieju

Fun rebase in store.

aapoalas avatar Feb 12 '23 19:02 aapoalas

Uno reverse by https://github.com/denoland/deno/pull/17899

image

opAsync will stay.

littledivy avatar Feb 23 '23 14:02 littledivy