deno icon indicating copy to clipboard operation
deno copied to clipboard

fix(Response): use byte stream for string or uint8array

Open crowlKats opened this issue 2 years ago • 4 comments

For #17386

crowlKats avatar Jan 13 '23 09:01 crowlKats

@crowlKats could you look into enabling relevant WPT tests for this change?

bartlomieju avatar Jan 13 '23 21:01 bartlomieju

@bartlomieju as per the linked issue, there currently arent any, this is a deno-specific problem; wpt tests around this will be available once the spec change is completed

crowlKats avatar Jan 13 '23 21:01 crowlKats

though seems wpts are failing for some reason. will investigate

crowlKats avatar Jan 13 '23 21:01 crowlKats

It's not enough to add type: "bytes" to get a usable byte stream. The controller.byobRequest value must be checked and used correctly in streams that set the type to bytes. This PR would cause the same issue that exists in Blob streams currently: https://github.com/denoland/deno/issues/14219#issuecomment-1407538689.

Macil avatar Jan 30 '23 19:01 Macil