deno icon indicating copy to clipboard operation
deno copied to clipboard

feat(http): return WebSocketStream from upgradeWebSocket

Open crowlKats opened this issue 3 years ago • 4 comments

Closes https://github.com/denoland/deno/issues/14064

crowlKats avatar Nov 21 '22 00:11 crowlKats

The WSS accessor needs to be locked behind --unstable.

lucacasonato avatar Nov 21 '22 01:11 lucacasonato

@lucacasonato done

crowlKats avatar Nov 21 '22 10:11 crowlKats

Would it be possible to test this API against this issue? https://github.com/denoland/deno/issues/17332

In Deno 1.29.2 WebSocketStream also exhibits this problem of dropping messages/chunks when sending from/to a live server, which seems like a bad thing for a streaming API.

sgwilym avatar Jan 12 '23 11:01 sgwilym

@bartlomieju there is a test for that already

crowlKats avatar Mar 19 '23 10:03 crowlKats