deno
deno copied to clipboard
fix(permissions): Disable prompt in `Deno.permissions.request()` when `--no-prompt` set
Closes #14668
In default implementation of Permissions
, it seems setting false
to prompt and that seems causing test failures. https://github.com/denoland/deno/blob/cc98a38c3a235536481550273e185651806e69e2/runtime/permissions.rs#L1161-L1173
Can you update it to pass the test cases? (Default impl itself seems used in create_child_permissions
. Probably it's not good idea to change default implementation. Maybe let's use literal construction in test cases)
Also can you add test cases (like test_request_no_prompt
next to test_request
) which performs the similar checks but with prompt: false
Yep! I'll come back around to this in a few days, sorry should have marked the PR as WIP - will do that now.
Hi @tom-sherman, thanks for the PR. I'm still interested in landing it, would you mind resolving merge conflicts?
@bartlomieju I don't think I'm going to be able to complete this, I'm having serious trouble building the project on my current machine. Going to close this PR so someone else can start work on it.