deno icon indicating copy to clipboard operation
deno copied to clipboard

segfault deserializing snapshot in tests

Open dsherret opened this issue 3 years ago • 2 comments

Seems like a segfault in v8 related to deserializing the snapshot.

image

error: test failed, to rerun pass '-p deno_runtime --lib'

Caused by:
  process didn't exit successfully: `C:\actions-runner\work\deno\deno\target\release\deps\deno_runtime-413c758822cbc9f4.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

https://github.com/denoland/deno/runs/7941098188?check_suite_focus=true

dsherret avatar Aug 25 '22 03:08 dsherret

https://github.com/denoland/deno/pull/15527 might fix it - we can get rid of ObjectTemplates.

littledivy avatar Aug 25 '22 03:08 littledivy

It seems to happen a lot:

https://github.com/denoland/deno/actions/runs/3046346801/jobs/4909043911

dsherret avatar Sep 13 '22 18:09 dsherret

Let's close this one and re-open if it happens again. Maybe fixed by #15527.

dsherret avatar Sep 22 '22 13:09 dsherret

This is still occurring https://github.com/denoland/deno/actions/runs/3106872198/jobs/5034292262

dsherret avatar Sep 22 '22 17:09 dsherret

Still failing https://github.com/denoland/deno/actions/runs/3322425538/jobs/5491428487 (and there have been others, of course)

dsherret avatar Oct 25 '22 16:10 dsherret

Still failing https://github.com/denoland/deno/actions/runs/3903822790/jobs/6668730830

dsherret avatar Jan 12 '23 17:01 dsherret

@piscisaureus and I will look into it next week

bartlomieju avatar Jan 12 '23 17:01 bartlomieju

Still failing: https://github.com/denoland/deno/actions/runs/4157500019/jobs/7192035069

aapoalas avatar Feb 12 '23 19:02 aapoalas

I get this constantly locally now (same segfault when deserializing the snapshot). I need to run my tests with one thread to get it to work.

dsherret avatar Apr 14 '23 20:04 dsherret

This has gotten a lot worse recently on my local machine. I hit it very often.

dsherret avatar Jan 04 '24 21:01 dsherret

I believe this was fixed by removing the cli_snapshot test which had some issues. @dsherret can we close this?

mmastrac avatar May 03 '24 15:05 mmastrac

For future ref, fixed by https://github.com/denoland/deno/pull/22722

mmastrac avatar May 03 '24 15:05 mmastrac