deno-gfm icon indicating copy to clipboard operation
deno-gfm copied to clipboard

/x does not render text as bold if followed by a hard line-break

Open clo4 opened this issue 3 years ago • 3 comments

It's entirely possible this bug is upstream.

Repro

The markup

- **Breaking: Changed how clients are instantiated with an API (#0)**\
  The API object must now be passed in as an api property on an object.

How GitHub renders it

  • Breaking: Changed how clients are instantiated with an API (#0)
    The API object must now be passed in as an api property on an object.

And on deno.land/x

image

Interestingly it seems to only affect lines that end with a non-alphanumeric character, but I haven't tested further. image

clo4 avatar Sep 23 '21 10:09 clo4

This is indeed caused by upstream, since dotland uses marked. You can see how the text rendered in the official demo:

image

For posterity, the deno.land page is https://deno.land/x/[email protected]/README.tpl.md.

kidonng avatar Oct 03 '21 06:10 kidonng

@hashrock does remark handle this case better?

lino-levan avatar Jul 04 '23 18:07 lino-levan

Yes it does

hashrock avatar Jul 04 '23 19:07 hashrock

@hashrock, I think this can be closed. When I go to https://deno.land/x/[email protected]/README.tpl.md?source=#version-020, I see the problematic text now rendered correctly.

deer avatar Jan 21 '24 18:01 deer

Agreed. It’s been a while since I had this problem, to be honest I forgot this issue was still open in the first place!

clo4 avatar Jan 21 '24 22:01 clo4