deno-gfm icon indicating copy to clipboard operation
deno-gfm copied to clipboard

Published 20 hours ago • verified publisher icon denoland

Write more tests

Open hashrock opened this issue 1 year ago • 3 comments

PR welcome!

  • [ ] transformMedia
  • [ ] allowIframes
  • [ ] disableHtmlSanitization
  • [ ] code block
  • [ ] browser tests - mainly CSS

I'm not looking to get coverage to 100%, but I'd like to get it to over 80%. you can check it by deno task coverage and deno coverage ./cov_profile

hashrock avatar Mar 09 '23 18:03 hashrock

Hi, can I please work on this issue?

ghost avatar Mar 10 '23 02:03 ghost

Of course!

hashrock avatar Mar 10 '23 05:03 hashrock

Can you assign the issue to me?

ghost avatar Mar 10 '23 08:03 ghost

@hashrock, looks like you added disableHtmlSanitization tests in https://github.com/denoland/deno-gfm/pull/62. So all we need now are the browser tests. Can you please elaborate on what you're looking for?

deer avatar Jan 15 '24 18:01 deer

Thanks for the catch!

The browser test was mentioned here:

https://github.com/denoland/deno-gfm/pull/49#issuecomment-1462381864

However, if the CSS is the same, the rendering result should not change, so we might not need to do browser testing here. or we might need a VRT? wdyt @lino-levan

hashrock avatar Jan 16 '24 04:01 hashrock