deno-astro-adapter icon indicating copy to clipboard operation
deno-astro-adapter copied to clipboard

Support for Astro @ 4.0?

Open joshgillies opened this issue 1 year ago • 22 comments

There's been a recent major release of Astro https://astro.build/blog/astro-4/, and from the looks of things this adapter should work, however the peerDependency expects astro@^3.0.13 https://github.com/denoland/deno-astro-adapter/blob/main/package.json#L37.

joshgillies avatar Dec 10 '23 03:12 joshgillies

I'm having issues updating to Astro 4 as well, error message:

Could not resolve '#async_hooks' from 'file:///.../node_modules/.deno/[email protected]/node_modules/p-limit/index.js'.

Hoping for an update of this adapter :-)

jueewo avatar Dec 14 '23 10:12 jueewo

+1

jose-donato avatar Jan 13 '24 22:01 jose-donato

+1

Astisme avatar Jan 22 '24 18:01 Astisme

Need fix for Astro 4.3.2 and beyond.

jamesli2021 avatar Feb 05 '24 11:02 jamesli2021

Need a fix as well. Was hoping to deploy my astro site on deno deploy.

aaronlifton avatar Feb 07 '24 04:02 aaronlifton

+1

lajbel avatar Feb 27 '24 20:02 lajbel

I saw on discord, that currently the node build with unstable flags is working in deno

https://discord.com/channels/684898665143206084/1204542187199668235/1204547434324426792

fro-profesional avatar Feb 27 '24 22:02 fro-profesional

@fro-profesional ok, but what is the point of using Deno if then i have to use an unstable flag build... nope, maybe i am to understand missing something?!

Looks like is not yet possible to consider using it atm… and its a pity, cos Astro is in the stack Deno is a maybe soon at this point, and i am sure i am not the only one

On 28 Feb 2024, at 06:38, Francisco Ramos @.***> wrote:

I saw on discord, that currently the node build with unstable flags is working in deno https://discord.com/channels/684898665143206084/1204542187199668235/1204547434324426792 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

toybreaker avatar Mar 03 '24 16:03 toybreaker

Is this adapter no longer maintained?

treb0r avatar Mar 09 '24 17:03 treb0r

Astro 4.5 dropped today 🚀🚀

treb0r avatar Mar 11 '24 16:03 treb0r

Astro is great 🚀🚀, but I gave up waiting for an update here. I assume it's not maintained anymore, Deno is even not mentioned on the Astro website (as far as I know this adapter was originally maintained by Astro, it seems it was took over by Deno and the development stopped).

jueewo avatar Mar 11 '24 18:03 jueewo

And that is a real bummer, cos when forced to pick many will stick to Astro and drop Deno, like we had to do...

Maybe the Deno focus now is on monetise the SAAS, but loosing early adoptioers is not quite a smart move...

On Tue, Mar 12, 2024, 2:56 AM Jürgen Wöckl @.***> wrote:

Astro is great 🚀🚀, but I gave up waiting for an update here. I assume it's not maintained anymore, Deno is even not mentioned on the Astro website (as far as I know this adapter was originally maintained by Astro, it seems it was took over by Deno and the development stopped).

— Reply to this email directly, view it on GitHub https://github.com/denoland/deno-astro-adapter/issues/10#issuecomment-1989210830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJ3YKJ4UCKD3LKQWL3J4LYXX45BAVCNFSM6AAAAABAOIBBY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGIYTAOBTGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

toybreaker avatar Mar 12 '24 03:03 toybreaker

Any update ?

Ayfri avatar Mar 12 '24 08:03 Ayfri

It looks like the problem has been solved, but an update to the npm registry has not yet been released. Temporarily, you can update package.json and install the adapter directly from the github repository - it helped in my case.

  "dependencies": {
    "@astrojs/deno": "github:denoland/deno-astro-adapter",
    "astro": "^4.5.9"
  }

So maybe the adapter will still be developed. Finger crossed 🤞🏻

skrzepij avatar Mar 22 '24 23:03 skrzepij

We changed the package name from @astrojs/deno to @deno/astro-adapter because of the change of the maintainers.

Now the latest version (v0.1.2) of @deno/astro-adapter should support astro 4.0.

kt3k avatar Apr 30 '24 10:04 kt3k

Please also update related document. https://docs.astro.build/en/guides/deploy/deno/

khoipro avatar May 25 '24 17:05 khoipro

hmm... Errors no longer occur, but process.env is not loaded

EdamAme-x avatar Jun 03 '24 11:06 EdamAme-x

my deps

{
  "name": "tmp",
  "type": "module",
  "version": "0.0.1",
  "scripts": {
    "dev": "deno run -A npm:astro dev",
    "start": "bun run dev",
    "build": "astro check && astro build",
    "preview": "deno run -A npm:astro preview",
    "astro": "astro",
    "format": "prettier --write ./**/*.{ts,astro}"
  },
  "dependencies": {
    "@astrojs/check": "^0.7.0",
    "@astrojs/react": "^3.4.0",
    "@astrojs/tailwind": "^5.1.0",
    "@deno/astro-adapter": "github:denoland/deno-astro-adapter",
    "@radix-ui/react-slot": "^1.0.2",
    "@types/react": "^18.3.3",
    "@types/react-dom": "^18.3.0",
    "astro": "^4.9.2",
    "astro-seo": "^0.8.4",
    "class-variance-authority": "^0.7.0",
    "clsx": "^2.1.1",
    "lucide-react": "^0.383.0",
    "prettier": "^3.3.0",
    "prettier-plugin-astro": "^0.14.0",
    "react": "^18.3.1",
    "react-dom": "^18.3.1",
    "tailwind-merge": "^2.3.0",
    "tailwindcss": "^3.4.3",
    "tailwindcss-animate": "^1.0.7",
    "typescript": "^5.4.5"
  },
  "prettier": {
    "tabWidth": 4,
    "useTabs": true,
    "singleQuote": false,
    "printWidth": 120,
    "bracketSameLine": false,
    "plugins": ["prettier-plugin-astro"],
    "overrides": [
      {
        "files": "*.astro",
        "options": {
          "parser": "astro"
        }
      }
    ]
  }
}

EdamAme-x avatar Jun 03 '24 11:06 EdamAme-x

@kt3k do you have any idea?

EdamAme-x avatar Jun 03 '24 11:06 EdamAme-x

hmm... Errors no longer occur, but process.env is not loaded

so my code throwing error.

EdamAme-x avatar Jun 04 '24 05:06 EdamAme-x

additional info: in develop mode

EdamAme-x avatar Jun 04 '24 05:06 EdamAme-x

DENO_FUTURE=1 resolved

EdamAme-x avatar Jun 04 '24 12:06 EdamAme-x