compress icon indicating copy to clipboard operation
compress copied to clipboard

Feature: Add `zip` support

Open arnu515 opened this issue 2 years ago • 7 comments

Can you add zip support using https://github.com/moncefplastin07/deno-zip ?

Thanks.

arnu515 avatar Apr 18 '22 07:04 arnu515

@arnu515 I guess I'll have time to deal with it in a week.

if you want, I am very happy to merge your pull request.

fuxingZhang avatar Apr 18 '22 10:04 fuxingZhang

@fuxingZhang I can create a PR but I won't be able to write tests since I don't have much free time

-------- Original Message -------- On 18 Apr 2022, 15:48, zfx wrote:

@.***(https://github.com/arnu515) I guess I'll have time to deal with it in a week.

if you want, I am very happy to merge your pull request.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

arnu515 avatar Apr 18 '22 10:04 arnu515

@arnu515 It's ok without unit tests.

fuxingZhang avatar Apr 18 '22 10:04 fuxingZhang

@arnu515 v1.2.3 has bug

https://github.com/moncefplastin07/deno-zip/commit/30f0f126f05b7a9f14952d43614f3f44ffa6f4b0

Fixed, but the author did not release 1.2.4

fuxingZhang avatar Apr 18 '22 10:04 fuxingZhang

I'll send the PR once the author updates the package

arnu515 avatar Apr 18 '22 10:04 arnu515

Any update ?

Inplex-sys avatar Jan 21 '24 21:01 Inplex-sys

Any update ?

Can you submit a pull request to support zip?

fuxingZhang avatar Jan 26 '24 13:01 fuxingZhang

Landed on v0.4.8

fuxingZhang avatar Nov 05 '24 03:11 fuxingZhang