Dennis Klein

Results 100 comments of Dennis Klein

I see three solutions: A. Do not hardcode the `lib` (and `include`) paths in the sanity check DSL: ```python sanity_check_is_file = [ join_path("include", "zmq.h"), join_path("lib", "libzmq.so"), join_path("lib", "pkgconfig", "libzmq.pc"), ]...

What is the preferred way to move this forward (besides rebasing)? Shall I split it into smaller PRs? Are you opposing any proposed changes I should drop (in other words,...

> > By the way, there are `clang-tidy` checks to do this automatically. > > Oh, I didn't know. Which ones do you mean? This looks like one: https://clang.llvm.org/extra/clang-tidy/checks/modernize/pass-by-value.html

What do the shell commands `which protoc` and `dpkg -S $(which protoc)` print?

Basically, the output shows that your anaconda environment is interfering with the FairSoft/FairRoot installation. Please restart the FairSoft/FairRoot installation procedures in a shell environment that does not have your anaconda...

This will become obsolete as we plan to make a future header-only release of FairMQ.

> Example of building CMake > > ``` > In file included from /usr/include/linux/fs.h:19, > #31 616.7 1570 from /tmp/user/spack-stage/spack-stage-cmake-3.25 > #31 616.7 .2-qp5x5vhdsqw3o4oclgwhm4menrzofofs/spack-src/Utilities/cmlibarchi > #31 616.7 ve/libarchive/archive_read_disk_posix.c:56: > #31...

For your curiosity, deleting `/home/dklein/spack/opt/spack/linux-fedora37-zen3/gcc-12.2.1/gcc-10.4.0-bqoje6ievt4jlrduolnkfyajuvtvl4xc/lib/gcc/x86_64-pc-linux-gnu/10.4.0/include-fixed/sys/mount.h` makes `[email protected]+ownlibs%[email protected]` compile just fine. ```console ❯ colordiff /home/dklein/spack/opt/spack/linux-fedora37-zen3/gcc-12.2.1/gcc-10.4.0-bqoje6ievt4jlrduolnkfyajuvtvl4xc/lib/gcc/x86_64-pc-linux-gnu/10.4.0/include-fixed/sys/mount.h /usr/include/sys/mount.h ``` ```diff 1,9d0 < /* DO NOT EDIT THIS FILE. < < It has been...

> Still not sure what would be the proper solution. Should we delete this file as a part of gcc package definition? Same, I am currently researching about this "include-fix"...