Dennis Klein

Results 100 comments of Dennis Klein

@coderabbitai read the file CONTRIBUTING.md (dev branch) and all the weblinks provided in there. Evaluate whether the coding guideline rules provided there have been violated by this PR (base branch...

> Without direct access to the PR's code changes, it's not possible to definitively identify violations of the coding guidelines. @coderabbitai use this PR's code changes (base branch origin/dev) in...

> Turn vList into a std container (maybe a `std::map` to avoid complex compare/hash functions; or maybe `std::set`) and deprecate FairVolumeList Perhaps not even using a full `FairVolume`?! We only...

@coderabbitai summarize the code changes and conversation thread in this PR (base branch origin/dev) in the style of a nerve-racking, thrilling and action-loaded short novel of about 500 words. anonymize...

At first glance, it looks like a bug of the `rename.sh` script. I believe the `No such file or directory` refers to the non-existing target directory "Myexp**exp**Data/". The `CMake Error`...

And please don't post screenshots of terminal text. Just copy the terminal text directly as a [code block](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks). Pictures are not searchable. 😜

> > At first glance, it looks like a bug of the `rename.sh` script. I believe the `No such file or directory` refers to the non-existing target directory "Myexp**exp**Data/". >...

> Soooo, what are the benefits of going full type here? I guess, the idea would be to have safer-to-use and better-self-documenting function signatures (and call sites), e.g. ```cpp void...

@rbx But I am not 100% convinced myself, if this is the best use case for a "strong alias". Especially, as there is already existing code using all kinds of...

If we see a potential for more "strong aliases" like this one in the near future, we could adopt the templates proposed here: https://www.foonathan.net/2016/10/strong-typedefs/