Dennis Kigen
Dennis Kigen
@senthil-k8s so one of the main things to take care of here is that deleting vitals and biometrics data should void the observations instead of deleting the encounter.
@ibacher so what's the ideal approach for @senthil-k8s to pursue w.r.t to voiding the observations using the Delete action?
@samuelmale do you mind clarifying what the approach should look like?
@senthil-k8s I've squashed your commits into a single one to ensure a cleaner commit history. This should simplify future rebasing and merges. Thank you for your understanding and contributions!
Ok, thanks, guys! Looks like this is good to go!
@ibacher @gitcliff The more I look at this, the more I think this behaviour should be put behind a config property so it's opt-in. Something like: ```ts export const configSchema...
Very late in the day, but I've just realized that we may have duplicated functionality here. See https://github.com/openmrs/openmrs-esm-patient-chart/pull/1059
Isn't [this](https://github.com/openmrs/openmrs-esm-patient-chart/blob/3a4f3493ad997ba525594ac7dd62e4ace2ab433e/packages/esm-patient-forms-app/src/hooks/use-forms.ts#L86) the exact same check?
Closing as a duplicate of https://github.com/openmrs/openmrs-esm-patient-chart/pull/1059. Sorry for the confusion, @gitcliff :)
I suspect this may have already been fixed in https://github.com/openmrs/openmrs-esm-patient-chart/pull/2019. Could you review and confirm, @vasharma05?