Dennis Gove

Results 26 comments of Dennis Gove

Appears to be failing with error ``` plugin_test.go:24:2: no required module provides package github.com/google/go-tpm-tools/tpm2tools; to add it: go get github.com/google/go-tpm-tools/tpm2tools FAIL github.com/bloomberg/spire-tpm-plugin/pkg/agent [setup failed] Stopping spire-tpm-plugin-ci ... The command "./ci/test.sh"...

Note: failed compilation should be expected until https://github.com/spiffe/spire-api-sdk/pull/29 is merged and the `go.sum` references the new version.

Thank you, @MarcosDY for your feedback. Every comment with a 👍 has been corrected. The only outstanding issue is the upgrade and downgrade question, for which I've posted my thoughts.

> rename the existing ttl field to x509_svid_ttl I have two concerns with this approach. Though please let me know if I'm misunderstanding the intent here. First, we've already added...

> the protobuf field number would remain the same, i.e., wire compatibility would not break. That is something I forgot about - thanks for clearing that up. This plan sounds...

Hi @azdagron. I do still feel comfortable hitting the OCtober 26th date. I had a little issue when I swapped my laptop to an M1 but have gotten that resolved.

@azdagron I *believe* I've made all the necessary changes, including in the tests. But I'm not 100% that I haven't missed something.

> Looks like we missed updating go.mod with the latest pseudo-version. CI/CD is also not passing. @azdagron, is this something I should be changing? If so, what should I change?

Thanks @azdagron. I plan to have those items pushed by tonight.

Thank you @azdagron and @MarcosDY for all your feedback and help with this change. I really appreciate it!