diopter-calc icon indicating copy to clipboard operation
diopter-calc copied to clipboard

Published 20 hours ago • verified publisher icon denisk20

Bug: Graph isn't displayed

Open Anonymyous678 opened this issue 1 year ago • 9 comments

Screenshot_2023-06-15-21-24-53-925-edit_org endmyopia calc Screenshot_2023-06-15-21-24-28-876-edit_org endmyopia calc Screenshot_2023-06-15-21-24-22-388-edit_org endmyopia calc Why the diopter history graph isn't displayed for me? I have saved enough measurements in history to generate it. I have the latest version of app downloaded from app store.

Anonymyous678 avatar Jun 15 '23 19:06 Anonymyous678

@denisk20 please take a look at it, do you need more info to debug it? I tried to export measurements, reinstall app, take 2 fresh measurements and graph was displayed, but once I imported my measurement data, it stopped displaying the graph. Should I send you the json file with measurements? Maybe it's some bug how it's saved there.

Anonymyous678 avatar Jun 15 '23 19:06 Anonymyous678

I haven't seen anything like this. If you post your json I can take a look.

denisk20 avatar Jun 15 '23 19:06 denisk20

Here it is: https://haste.cluster.ws/raw/uhodedowevoburoqiwegefaki @denisk20

Anonymyous678 avatar Jun 16 '23 16:06 Anonymyous678

@denisk20 So, did you check it?

Anonymyous678 avatar Jun 20 '23 13:06 Anonymyous678

Thanks for submitting it. I was able to reproduce the issue. I'll try to fix it in the upcoming days and update the app. Will let you know when it's ready.

denisk20 avatar Jun 21 '23 18:06 denisk20

It seems there's a problem with the chart library that I use, it simply can't handle such amounts of measurements. I need to update the logic to interpolate the values for the chart. This is not a quick fix, I'll post here when it's done.

denisk20 avatar Jun 21 '23 19:06 denisk20

Ok thanks

Dňa st 21. 6. 2023, 21:45 Denis Kniazhev @.***> napísal(a):

It seems there's a problem with the chart library that I use, it simply can't handle such amounts of measurements. I need to update the logic to interpolate the values for the chart. This is not a quick fix, I'll post here when it's done.

— Reply to this email directly, view it on GitHub https://github.com/denisk20/diopter-calc/issues/9#issuecomment-1601573985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYDCUYJ6J2E2JCUUSCUSITXMNFOVANCNFSM6AAAAAAZIJPOCY . You are receiving this because you authored the thread.Message ID: @.***>

Anonymyous678 avatar Jun 22 '23 05:06 Anonymyous678

I have made progress here, I have re-written all of the chart code to not use the problematic library. The chart might not look as pretty as before and is not zoomable, also one can't delete items directly from the chart anymore, but it should be fast and reliable (will test with large datasets). It should be ready in couple days.

denisk20 avatar Jun 30 '23 07:06 denisk20

It's ready, the build is in Open Testing channel, I'll test on couple more phones and will release to the public.

denisk20 avatar Jun 30 '23 10:06 denisk20