go-mssqldb icon indicating copy to clipboard operation
go-mssqldb copied to clipboard

Published 20 hours ago • verified publisher icon denisenkom

Fixed issues with TVPs

Open Woody1193 opened this issue 3 years ago • 3 comments

This PR fixes two recently uploaded issues wherein TVP checking will fail if the value was a slice of pointers and where TVP will not ignore internal fields.

Woody1193 avatar Nov 20 '20 13:11 Woody1193

Can you write the any test? I don't understand your fix

NikitaDef avatar Nov 22 '20 23:11 NikitaDef

Ah, my apologies. I dug into the code a little more and discovered that I hadn't implemented the changes correctly. Essentially, these are supposed to support conversion of a slice of pointers to a TPV and to ignore unexported fields when converting TPV data to SQL data.

Woody1193 avatar Nov 24 '20 03:11 Woody1193

This change alters renames a number of existing fields. Please revert. Please also document what type of values this accepts, include in comments with examples of what this solves.

kardianos avatar Jul 08 '21 14:07 kardianos