Denis Yuen

Results 289 comments of Denis Yuen

> IMHO, this should be a 1.13.x hotfix ticket, since it appears to derail our preferred registration process. 👍

> I was just about to comment on the PR that this should target the hotfix branch, based on the milestone, but then noticed this ticket is for the new...

> 1. The code only creates a new request after the size of the current request [exceeds that limit](https://github.com/elastic/elasticsearch/blob/v7.10.2/server/src/main/java/org/elasticsearch/action/bulk/BulkProcessor.java#L442), but doesn't reduce the size of the request, it just creates...

> 2\. There are currently no entries where a single version causes more than 10MB to be indexed, so I feel this is pretty safe for the hotfix. Presumably it...

This is all true. In fact, I would go a little further and say that even linking to a tagged commit may be insufficient. Tags can be deleted and re-created....

This probably needs to be split up* but will be important for implementing TRS 2.0.1 which includes information on what versions of the workflow languages the descriptors in a workflow...

also interested /remove-lifecycle stale

Similar to https://github.com/dockstore/dockstore/issues/4048 (i.e. debate whether warning should be in stdout or stderr)

May be mitigated by https://github.com/dockstore/dockstore/issues/5054 (should have fewer messages like these)

think this was accidentally dealt with during https://github.com/dockstore/dockstore/pull/4810