html5-knob

html5-knob copied to clipboard

1) Replace `document.registerElement` with `customElements.define`. 2) Replace `createShadowRoot` with `attachShadow`. 3) Get rid of `document.writeln`, which is unsupported and unneeded. Up-to-date as of Oct 23, 2022.

jenna-h

Would be awesome if you include an inertial effect on the knob when it is rotated, just like the GSAP draggable.

astik-dahal

lets merge the patch from @BramVerb * indent with spaces * use let, const * shorter syntax * use class * (more?) maybe split the commit in * fix indent...

milahu

document.registerElement is deprecated in Chrome not present in Safari

1

They're removing this in favor of window.customElements.define() in June 2019 https://www.chromestatus.com/features/4642138092470272

bfod

The demo page works fine if you visit in desktop Safari, but in mobile Safari none of the controllers display.

bfod

We're supposed to use attachShadow({mode: 'closed'}); now

bfod

I'm happy to submit this as a pull request if you'd like? https://www.webcomponents.org/publish

ZachMoreno