docker-hs icon indicating copy to clipboard operation
docker-hs copied to clipboard

defaultHttpHandler and unixHttpHandler use ResponseTimeoutDefault

Open mbg opened this issue 4 years ago • 0 comments

Both defaultHttpHandler and unixHttpHandler use defaultManagerSettings for which responseTimeout = ResponseTimeoutDefault. This just came to bite me when I used the waitContainer API with a non-trivial container task. It seems that the /wait API does not send a response until the container has stopped, so using ResponseTimeoutDefault does not make much sense here. I am wondering whether:

  • It would make sense to document this and add a suitable warning to the documentation for waitContainer?
  • Modifying the request made in waitContainer to override the responseTimeout to set it to ResponseTimeoutNone?

mbg avatar Apr 06 '20 01:04 mbg