org-caldav icon indicating copy to clipboard operation
org-caldav copied to clipboard

Add days-in-past to keep the remote calendar clean.

Open whirm opened this issue 4 years ago • 5 comments


Also clean up mixed tabs and indentation.

Original "days in past" commit author: Martin Kaffanke <m.kaffanke_at_gmail.com>

After/if this PR gets merged I've got some more changes I've collected from various forks (like vtodo support) cleaned up so they apply on top of this.

whirm avatar Feb 28 '20 22:02 whirm

Thanks for your work. I'm usually opposed to commits only containing tab/whitespace changes because IMO it's a non-issue and makes git-blame more tedious. Are these really necessary?

dengste avatar May 01 '20 19:05 dengste

Problems with indention some time render the code difficult to read. It make this code more difficult to correct and improve that it should be.

vanicat avatar May 02 '20 16:05 vanicat

I what way is the code difficult to read? Because of the tabs? If so, then you deliberately changed the defaults for Emacs-Lisp mode. Leave 'tab-width' at '8' and everything will be fine. If you look at the Emacs code base, you will see that there's also a wild mixture of tabs and whitespace. It's really a non-issue unless you change 'tab-width' or otherwise make tabs explicitly visible.

dengste avatar May 02 '20 16:05 dengste

Okay, sorry, I wrote my comment based on memory, and i cannot find in the current code the problem I had in mind. I should have checked before writing my comment.

vanicat avatar May 03 '20 08:05 vanicat

I've rebased against current master and fixed @vanicat's comments. I've removed the white space cleanup commits from this PR for now and I'll see if it makes bringing in other changes not too annoying.

whirm avatar Jul 29 '20 19:07 whirm