Doug Engert

Results 472 comments of Doug Engert

@vletoux @metsma Can you look at this PR, especially in the customactions.cpp and the comment in OpenSC.wxs.in: ``` ```

Implementation of this PR will affect existing installations because the "Crypto Provider" is saved in the cert store as "Provider". The `certutil -Silent -store -user My` can be used list...

What powershell command did you use? "Microsoft Base Smart Card Crypto Provider" only supports RSA See: https://docs.microsoft.com/en-us/windows-hardware/drivers/smartcard/smart-card-minidrivers "Microsoft Smart Card Key Storage Provider" is the KSP. So it looks like...

While reviewing this PR and #2575 the minidriver is called at: https://github.com/OpenSC/OpenSC/pull/2523/files#diff-0472a0d91e9f422e4d90a09074f95d9edf67b14a2df432fcb3aacca29b9a3b39L4424 which calls [md_query_key_sizes](https://github.com/OpenSC/OpenSC/pull/2523/files#diff-0472a0d91e9f422e4d90a09074f95d9edf67b14a2df432fcb3aacca29b9a3b39L2723) with the dwKeySpec dwKeySpec is a combination of: ECC key, a specific usage (ECDSA or...

I am not referring to CardCreateContainer but to CardQueryKeySizes: ![CardQueryKeySizes](https://user-images.githubusercontent.com/865329/178483848-d36babb6-c8e1-49f1-b64d-efb039e6308d.JPG) which says: "Key size information is returned in the following structure. For ECC, minimum, default, and maximum are a specific...

> I don't have a way to test this, but the only comment I would have here would be the typo marked by the codespell. The remaining codespell reports are...

Yes I was able to test this with PIV card with EC keys. But on Windows OpenSC does not add PIV to the registry, because most, PIV card vendors provide...

In other words it is ready to commit. It does not break anything, only made improvements.

If you use OpenSC on Windows, especially if you were having problems with EC keys, can you try installing OpenSC from https://github.com/OpenSC/Nightly Uninstall any current OpenSC packages both 64 and...

One more issue is cached ATR that may cause Microsoft minidriver for PIV to get called. Sent from my phone. More later On Fri, Apr 15, 2022, 8:32 AM Doug...