dendron icon indicating copy to clipboard operation
dendron copied to clipboard

chore: streamline common-assets styles

Open namjul opened this issue 3 years ago • 2 comments

This PRs aim is to collect the scattered css styles back into common-all. Specifically the scss styles for dendron-plugin-views and nextjs-template. It adds two new scss files main-next.scss and main-plugin.scss that contain context specific styles and levels out the common styles only back into main.scss (and its dependend files).

The asset sync (distribution of the styles from common-all into views and next) is refactored to only be done from the dendron dev sync_assets cli command.

It also removes some unused code found during the implementation.

  • [ ] document a workflow for editing styles

Pull Request Checklist

If you are a community contributor, copy and paste the PR template from Dendron Community PR Checklist and add it to the body of the pull request.

If you are a team member, copy and paste the template from Dendron Extended PR Checklist.

To copy the template, click on the Raw button on the gist to copy the plaintext version of the template to this PR.

namjul avatar Sep 21 '22 09:09 namjul

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '22 09:09 CLAassistant

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Samuel Hobl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

@namjul are you using a different email for this pr? if so, can you make sure to make an offering to the CLA bot?

kevinslin avatar Sep 21 '22 14:09 kevinslin

can you rebase to resolve the conflicts?

kevinslin avatar Sep 27 '22 17:09 kevinslin