dendron icon indicating copy to clipboard operation
dendron copied to clipboard

Email autolinks not working

Open jeep opened this issue 3 years ago • 4 comments

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • [ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • [ ] Lookup. Dendron's Lookup Command
  • [ ] Views. Dendron Preview, Tree View, Side Panels in the UI
  • [ ] Schema. Dendron Schemas
  • [ ] Pod. Data import from / export to Dendron
  • [ ] Publish. External Site Publish
  • [X] Markdown. Markdown features, such as syntax support and features

Describe the bug

Dendron does not handle email autolinks. (https://github.github.com/gfm/#email-autolink)

To Reproduce

Steps to reproduce the behavior:

  1. Open a new markdown document
  2. Create an email autolink by typing an email address surrounded by angle brackets. For example: <[email protected]>
  3. Open Dendron Preview (if it is not already open) a. Open Command Palette b. Dendron: Toggle Preview
  4. Click on the email address link in the preview
  5. Observe nothing happens
  6. Similarly (and I can open another bug if you don't want two observations in a single repro step chain) in the md document, position the cursor over any character of the email address
  7. Open Command Palette
  8. execute Dendron: Go to
  9. Observe nothing happens

Expected behavior

Default mail program opens with To: line filled with the email address in both cases. To see the expected preview behavior, you can open the built in preview pane (Command Palette, Markdown: Open Preview) and click the link in the preview pane.

Desktop (please complete the following information)

  • OS: Windows 11
  • Versions (all that apply to bug):
    • Dendron Extension: v0.113.1
    • VS Code version: 1.71.2

Additional context

Potentially related issue: #518

jeep avatar Sep 21 '22 05:09 jeep

Hey @jeep, thanks for raising the issue. I can repro this. This is not yet supported by Dendron: Go To, I would add this as an enhancement request. Tagging @hikchoi for visibility.

Harshita-mindfire avatar Sep 21 '22 07:09 Harshita-mindfire

Thanks for the report @jeep

We'll let you know when we add support for the gfm email autolinks.

For the time being, here's a workaround you can use:

While limited, you can do the following with wikilinks:

[[send email to me|mailto:[email protected]]]
  1. When using preview, this will be clickable and will open the default email client in your system.
  2. When in markdown, Open Link and Go To will not work, but if you hover over the text in the editor, you will be provided with a clickable link like so: image

hikchoi avatar Sep 21 '22 08:09 hikchoi

Okay, so is the request for me to open a new feature request issue? Or is that not needed? I thought I saw someplace where Dendron said GFM was supported, so I had assumed this was a bug. Is there someplace I can see what markdown is supported so I don't make this mistake in the future?

jeep avatar Sep 21 '22 14:09 jeep

@jeep No further action needed.

I thought I saw someplace where Dendron said GFM was supported, so I had assumed this was a bug.

Since simply clicking on the rendered email autolink in preview isn't working, that is actually a bug.

but supporting it in Go to is something that we haven't implemented yet, and for that it would be an enhancement / feature request. You are welcome to create a separate one if you wish, but I would say this issue is sufficient.

Regardless, we are now aware of this and that's what matters. Sorry about the confusion with the issue labeling. This is just triaging specifics.

hikchoi avatar Sep 22 '22 01:09 hikchoi