dendron icon indicating copy to clipboard operation
dendron copied to clipboard

`Move Selection To` to a non-existent note does not respect `vaultSelectionModeOnCreate` when `alwaysPrompt`

Open ScriptAutomate opened this issue 3 years ago • 3 comments

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • [x] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • [ ] Lookup. Dendron's Lookup Command
  • [ ] Views. Dendron Preview, Tree View, Side Panels in the UI
  • [ ] Schema. Dendron Schemas
  • [ ] Pod. Data import from / export to Dendron
  • [ ] Publish. External Site Publish
  • [ ] Markdown. Markdown features, such as syntax support and features

Describe the bug

Dendron: Move Selection To on a link to a non-existent note does not respect vaultSelectionModeOnCreate when set to alwaysPrompt. It may also not be respecting smart mode if set to that, as I can only confirm testing where it is just creating the note in the vault of the current note context.

To Reproduce

  1. Setup a multi-vault
  2. Set the following values in root vault dendron.yml
commands:
    lookup:
        note:
            confirmVaultOnCreate: true
            vaultSelectionModeOnCreate: alwaysPrompt
            leaveTrace: true
workspace:
    enableXVaultWikiLink: true
  1. Reload window
  2. Create a note in one vault
  3. Type a sentence: This is a sentence that is going to be moved!
  4. Highlight and use Dendron: Move Selection To to create a new note where the content will be moved to a new note in the other vault, and a leaveTrace will place a wikilink to
  5. You will see note is created in vault of the current note context without any vault prompt

Expected behavior

Expect the value set in vaultSelectionModeOnCreate to be respected by Move Selection To, and not just use the vault of the current note context.

Desktop (please complete the following information)

  • OS: Pop!_OS 22.04
  • Versions (all that apply to bug):
    • Dendron Extension: v0.112.0
    • VS Code version: v1.71.2

ScriptAutomate avatar Sep 20 '22 00:09 ScriptAutomate

Thanks for the catch Derek!

Contemplating now if vaultSelectionModeOnCreate belongs in this namespace; at this point we have multiple ways a note can be created and is not necessarily tied to the note lookup command. This might make more sense in a higher namespace like workspace.

Anyways, I'll let you know when progress has been made.

hikchoi avatar Sep 20 '22 06:09 hikchoi

for triage @jonathanyeung:

[[Move Selection to to a Non Existent Note Does Not Respect Vaultselectionmodeoncreate When Alwaysprompt|dendron://private/task.2022.09.20.move-selection-to-to-a-non-existent-note-does-not-respect-vaultselectionmodeoncreate-when-alwaysprompt]]

hikchoi avatar Sep 20 '22 06:09 hikchoi

If there is any known work-around to this, I would love to hear it. This is the one unsurmountable barrier I've found to my adoption to Dendron

jeep avatar Sep 22 '22 01:09 jeep