dendron icon indicating copy to clipboard operation
dendron copied to clipboard

Iframe noteref rebase

Open hkievet opened this issue 3 years ago • 2 comments

Dendron Extended PR Checklist

  • NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code

Basics

Extended

  • General
    • [ ] check whether code be simplified
    • [ ] check if similar function already exist in the codebase. if so, can it be re-used?
    • [ ] check if this change adversely impact performance
  • Operations
    • [ ] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • [ ] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • [ ] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

  • [ ] Write Tests
  • [ ] Confirm existing tests pass
  • [ ] Confirm manual testing
  • [ ] Common cases tested
  • [ ] 1-2 Edge cases tested
  • [ ] If your tests changes an existing snapshot, snapshots have been updated

Extended

  • [ ] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
  • CSS
    • [ ] display is correct for following dimensions
      • [ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
      • [ ] lg: screen ≥ 992px
      • [ ] xxl: screen ≥ 1600px eg. mac (1600x900)
    • [ ] display is correct for following browsers (across the various dimensions)
      • [ ] safari
      • [ ] firefox
      • [ ] chrome

Docs

  • [ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • [ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Extended

  • [ ] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

hkievet avatar Sep 17 '22 00:09 hkievet

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 17 '22 00:09 CLAassistant

can you create a test case for when noterefs exceed 3 levels? at that point, it will be easier to debug and we'll have a test case to green light when we fix the issue

kevinslin avatar Sep 22 '22 15:09 kevinslin

did this test fail? https://github.com/dendronhq/dendron/actions/runs/3114309271/jobs/5050002762

kevinslin avatar Sep 24 '22 14:09 kevinslin

TreeViewUtils doesn't exist anymore - looks like a rebase error

kevinslin avatar Sep 28 '22 00:09 kevinslin

TreeViewUtils doesn't exist anymore - looks like a rebase error

I'm incredibly confused why this isn't showing up in the PR diff...

hkievet avatar Sep 28 '22 17:09 hkievet