dendron
dendron copied to clipboard
Iframe noteref rebase
Dendron Extended PR Checklist
- NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export
Code
Basics
- [x] code should follow Code Conventions
- [x] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core. See Avoiding Circular Dependencies.
- [ ] sticking to existing conventions instead of creating new ones
Extended
- General
- [ ] check whether code be simplified
- [ ] check if similar function already exist in the codebase. if so, can it be re-used?
- [ ] check if this change adversely impact performance
- Operations
- [ ] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
- Architecture
- [ ] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed
Instrumentation
Basics
- [ ] if you are adding analytics related changes, make sure the Telemetry docs are updated
Extended
- [ ] can we track the performance of this change to know if it is successful?
Tests
Basics
- [ ] Write Tests
- [ ] Confirm existing tests pass
- [ ] Confirm manual testing
- [ ] Common cases tested
- [ ] 1-2 Edge cases tested
- [ ] If your tests changes an existing snapshot, snapshots have been updated
Extended
- [ ] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
- CSS
- [ ] display is correct for following dimensions
- [ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
- [ ] lg: screen ≥ 992px
- [ ] xxl: screen ≥ 1600px eg. mac (1600x900)
- [ ] display is correct for following browsers (across the various dimensions)
- [ ] safari
- [ ] firefox
- [ ] chrome
- [ ] display is correct for following dimensions
Docs
- [ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
- [ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages
Close the Loop
Extended
- [ ] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop
can you create a test case for when noterefs exceed 3 levels? at that point, it will be easier to debug and we'll have a test case to green light when we fix the issue
did this test fail? https://github.com/dendronhq/dendron/actions/runs/3114309271/jobs/5050002762
TreeViewUtils doesn't exist anymore - looks like a rebase error
TreeViewUtils doesn't exist anymore - looks like a rebase error
I'm incredibly confused why this isn't showing up in the PR diff...