dendron icon indicating copy to clipboard operation
dendron copied to clipboard

Note preview does not render spaces around links in headers

Open samuelxyz opened this issue 3 years ago • 2 comments

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • [ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • [ ] Lookup. Dendron's Lookup Command
  • [x] Views. Dendron Preview, Tree View, Side Panels in the UI
  • [ ] Schema. Dendron Schemas
  • [ ] Pod. Data import from / export to Dendron
  • [ ] Publish. External Site Publish
  • [x] Markdown. Markdown features, such as syntax support and features

Describe the bug

When a link is inserted in the middle of a header, the Dendron markdown preview does not render any spaces around the link. For example,

Header with a link in it

appears as

Header with alinkin it

To Reproduce

Steps to reproduce the behavior:

  1. Inside a note, try to put a hyperlink ([link](address)) or note wikilink ([[link]]) inside a header, with other words before and/or after the link.
  2. Open the markdown preview and observe how the header is rendered.

Expected behavior

Spaces appear before and after the link in the header.

Screenshots

Raw markdown:

image

What the preview shows:

image

Desktop (please complete the following information)

OS: Windows 11 Home 10.0.22000 Browser (if with published websites; include version): N/A Versions (all that apply to bug): Dendron Extension: v0.107.2 VS Code version: 1.70.1 Dendron CLI:

Additional context

Add any other context about the problem here.

Dendron Log file

dendron.log

samuelxyz avatar Aug 13 '22 04:08 samuelxyz

Thank you for the report. I can reproduce this. We'll let you know when this gets resolved

hikchoi avatar Aug 16 '22 03:08 hikchoi

Reopening because #3403 did only apply the fix to the preview but not to publishing (nextjs-template)

namjul avatar Aug 29 '22 07:08 namjul

This has been fixed in https://github.com/dendronhq/dendron/pull/3525

namjul avatar Oct 10 '22 09:10 namjul