dendron
dendron copied to clipboard
dendronhq
Go to next sibling doesn't cross month
Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)
- [x] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
- [ ] Lookup. Dendron's Lookup Command
- [ ] Views. Dendron Preview, Tree View, Side Panels in the UI
- [ ] Schema. Dendron Schemas
- [ ] Pod. Data import from / export to Dendron
- [ ] Publish. External Site Publish
- [ ] Markdown. Markdown features, such as syntax support and features
Describe the bug
Going from 1 Aug -> 31 July -> 1 Aug doesn't work I end up on 1 July instead.
To Reproduce
Steps to reproduce the behavior:
- Ensure you have journal notes for the 1st July, 30th July, 31st July, 1st August
- Go to the 1st August note
- Run the "Dendron: Go to previous sibling" command
- Run the "Dendron: Go to next sibling" command
- Note that you're now on the 1st of July's note and not the 1st of August's note
Expected behavior
It should go back and forth across the month boundary.
Desktop (please complete the following information)
- OS: macOS
- Versions (all that apply to bug):
- Dendron Extension: 0.105.2
- VS Code version: VSCodium 1.69.2
Additional context
I also just reported #3330. Between the two, it looks like there is some kind of bug somewhere in the month navigation code. Maybe the two issues are related. My suspicion is that somehow I'm seeing the old behaviour at some times, and the new at others. For example, navigating from 1 July back goes to 30 June, then forward to 1 July. But from 31 July forward consistently goes to 1 July.
Maybe there's an issue with months which have 31 days? May seems to work consistently for me though. Sorry I can't provide a more concrete reproduction.
Dendron Log file
Please attach the output of > Dendron:Dev: Open Logs here
@chmac Thanks for reporting the bug. This looks like a duplicate of https://github.com/dendronhq/dendron/issues/688. Can you check if this issue coincides with the existing one?
@Harshita-mindfire Well, I'm not sure. I saw that issue before reporting this, but that issue seems to say that the commands should work differently, that they should cross month boundaries. I understood that #688 was a feature request in effect, not a bug report. While there's a note in that issue to say this has been (partially?) implemented. So the reason I opened a separate issue is because that implementation seems to have a bug.
But if you think #688 is the correct ticket to track this bug with the implementation, then I'm happy to close this and move the topic there. My concern would be that this problem gets lost in the discussion on #688 because there's a lot of "this is the intended behaviour" messages in that thread.
sounds good. let's keep this open then. Adding this to our backlog