dendron
dendron copied to clipboard
feat(views): UI to configure `dendron.yml`
This PR aims to create a UI to configure dendron.yml BREAKING CHANGE(dependency update): updated antd version to 4.21 vsix: https://github.com/dendronhq/dendron/actions/runs/2816139489 Development-Docs: https://github.com/dendronhq/dendron-docs/pull/31
Dendron Extended PR Checklist
- NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export
Code
Basics
- [x] code should follow Code Conventions
- [x] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core. See Avoiding Circular Dependencies.
- [x] sticking to existing conventions instead of creating new ones
Extended
- General
- [x] check whether code be simplified
- [x] check if similar function already exist in the codebase. if so, can it be re-used?
- [x] check if this change adversely impact performance
- Operations
- [x] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
- Architecture
- [~] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed
Instrumentation
Basics
- [~] if you are adding analytics related changes, make sure the Telemetry docs are updated
Extended
- [~] can we track the performance of this change to know if it is successful?
Tests
Basics
- [ ] Write Tests
- [ ] Confirm existing tests pass
- [x] Confirm manual testing
- [ ] Common cases tested
- [ ] 1-2 Edge cases tested
- [ ] If your tests changes an existing snapshot, snapshots have been updated
Extended
Docs
- [ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
- [x] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages
Close the Loop
Extended
- [x] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop
@Harshita-mindfire - looks like there's a build issue:
"src/utils/ExtensionUtils.ts(71,19): error TS2304: Cannot find name 'getDWorkspace'.\n" +
EDIT: this is from main.
@Harshita-mindfire no rush - can you ping me when this is ready to re-review with the sub-grouped configs?
@Harshita-mindfire no rush - can you ping me when this is ready to re-review with the sub-grouped configs?
@kevinslin ready for re-review
- can we remove the following configuration (for the ui, we should just expose 'high level' configuration)
@kevinslin updated! https://github.com/dendronhq/dendron/actions/runs/2845068689