dendron icon indicating copy to clipboard operation
dendron copied to clipboard

feat: Schema Validator Page

Open maxkrieger opened this issue 2 years ago • 4 comments

This PR will contribute the first portion of [[Graphical Schema Interface|proj.2022.graphical-schema-interface]]

Pull Request Checklist

Code

Basics

Extended

  • General
    • [ ] check whether code be simplified
    • [ ] check if similar function already exist in the codebase. if so, can it be re-used?
    • [ ] check if this change adversely impact performance
  • Operations
    • [ ] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • [ ] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • [ ] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

  • [ ] Write Tests
  • [ ] Confirm existing tests pass
  • [ ] Confirm manual testing
  • [ ] Common cases tested
  • [ ] 1-2 Edge cases tested
  • [ ] If your tests changes an existing snapshot, snapshots have been updated

Extended

  • [ ] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
  • CSS
    • [ ] display is correct for following dimensions
      • [ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
      • [ ] lg: screen ≥ 992px
      • [ ] xxl: screen ≥ 1600px eg. mac (1600x900)
    • [ ] display is correct for following browsers (across the various dimensions)
      • [ ] safari
      • [ ] firefox
      • [ ] chrome

Docs

  • [ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • [ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Extended

  • [ ] is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

maxkrieger avatar Feb 26 '22 07:02 maxkrieger

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 26 '22 07:02 CLAassistant

can you rebase off of master? we've had a lot of changes that made it in since this branch was created

kevinslin avatar Apr 11 '22 17:04 kevinslin

also, don't forget the CLA :)

kevinslin avatar Apr 11 '22 17:04 kevinslin

Will do!

maxkrieger avatar Apr 12 '22 08:04 maxkrieger