dendron icon indicating copy to clipboard operation
dendron copied to clipboard

File links with spaces

Open aglucky opened this issue 3 years ago • 7 comments

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • [ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • [ ] Lookup. Dendron's Lookup Command
  • [ ] Views. Dendron Preview, Tree View, Side Panels in the UI
  • [ ] Schema. Dendron Schemas
  • [ ] Pod. Data import from / export to Dendron
  • [ ] Publish. External Site Publish
  • [ x] Markdown. Markdown features, such as syntax support and features

Describe the bug

File links will not work if there is a space or %20 in the name

To Reproduce

Steps to reproduce the behavior:

  1. Add a file with spaces in the name to assets
  2. Link the file to a note and view the markdown preview
  3. Click link
  4. See error

Expected behavior

Linked file should appear.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

  • OS: [e.g. windows]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]

Additional context

Add any other context about the problem here.

Dendron Log file

Please attach the output of > Dev:Dendron: Open Logs here

aglucky avatar Jan 20 '22 14:01 aglucky

Thank you for the report.

We will be investigating this and pushing a fix as soon as possible.

hikchoi avatar Jan 21 '22 16:01 hikchoi

This has been resolved with v80.

Feel free to let us know in this issue if you still have outstanding concerns. Otherwise this issue will be automatically closed in 3 days.

hikchoi avatar Feb 03 '22 01:02 hikchoi

This issue has been automatically closed because there has been no response to our request for more information from the original author. We don't have enough information to take action. Please reopen if the question from the maintainer has been answered and the issue is still valid.

no-response[bot] avatar Feb 06 '22 02:02 no-response[bot]

This is not fixed in v88 or v89. I have an image in assets/images/foo bar.png. If I use the text ![foo](assets/images/foo bar.png) the text is rendered literally. If I use the text ![foo](assets/images/foo%20bar.png) it renders a broken image icon.

cwtowns avatar Apr 05 '22 18:04 cwtowns

I can confirm it's not working correctly in 0.89.

aleksey-rowan avatar Apr 08 '22 01:04 aleksey-rowan

This issue has been automatically closed because there has been no response to our request for more information from the original author. We don't have enough information to take action. Please reopen if the question from the maintainer has been answered and the issue is still valid.

no-response[bot] avatar Apr 08 '22 02:04 no-response[bot]

This is still a problem in v0.119.0. I am trying to use a link to a pdf file that has spaces in the name: e.g.: "My local file.pdf"

[My local file](file:///home/myname/test/My local file.pdf)

If, however, I rename the file to: "My_local_file.pdf"

[My local file](file:///home/myname/test/My_local_file.pdf)

Then it works as expected and opens the file in the system's default application, which is Firefox. Also, using "assets/..." gives the same results in both cases.

bewillcott avatar Apr 13 '23 02:04 bewillcott